[Cadence] Allow specifying annotations on services

banzaicloud / banzai-charts

Curated list of Banzai Cloud Helm charts used by the Pipeline Platform

Apache License 2.0

368 stars 284 forks source link

[Cadence] Allow specifying annotations on services #1304

Closed johnkost closed 3 years ago

johnkost commented 3 years ago

Q	A
Bug fix?	no
New feature?	yes
API breaks?	no
Deprecations?	no
Related tickets	fixes #1303
License	Apache 2.0

What's in this PR?

Allows passing in additional annotations to the services created by cadence

Checklist

[x] Code meets the Developer Guide
[x] User guide and development docs updated (if needed)
[x] Related Helm chart(s) updated (if needed)

johnkost commented 3 years ago

@sagikazarmark @pregnor - Thanks for the approvals! I don't have write access so I can't merge this. Can one of you merge this?

pregnor commented 3 years ago

Sure, I can do that later today, I am finishing up the manual pre-release tests.

Would you prefer waiting for your other PR and release the 2 changes in a single version or should I release them separately as soon as merged?

johnkost commented 3 years ago

Sure, I can do that later today, I am finishing up the manual pre-release tests.

Would you prefer waiting for your other PR and release the 2 changes in a single version or should I release them separately as soon as merged?

Lets do individual. I still need to make changes to the other one. Thank you!

pregnor commented 3 years ago

In that case please also don't forget to bump the patch version number in your second PR.