updates cadence templates with grpcPort - Githubissues

banzaicloud / banzai-charts

Curated list of Banzai Cloud Helm charts used by the Pipeline Platform

Apache License 2.0

367 stars 278 forks source link

updates cadence templates with grpcPort #1306

Closed bdelano closed 2 years ago

bdelano commented 2 years ago

Q	A
Bug fix?	no
New feature?	yes
API breaks?	no
Deprecations?	no
Related tickets	mentioned in #1305
License	Apache 2.0

What's in this PR?

adds grpcPort to server-service and server-deployment templates

Why?

candence clients can now use GRPC for transport which means port 7833 needs be exposed on the cadence-frontend

Additional context

I have been using this branch in our development k8s environment and everything seems to be working as expected

Checklist

[x] Code meets the Developer Guide

To Do

[ ] update documents to reflect the availability of GRPC

bdelano commented 2 years ago

I think there are some fundamental problems with this as I can't get it to work so I am pulling this request