search

banzaicloud / banzai-charts

Curated list of Banzai Cloud Helm charts used by the Pipeline Platform
Apache License 2.0
368 stars 284 forks source link

[thanos] remove default sidecar selector #1309

Closed maciekm closed 3 years ago

maciekm commented 3 years ago
Q A
Bug fix? yes
New feature? no
API breaks? yes
Deprecations? no
Related tickets N/A
License Apache 2.0

What's in this PR?

Removes default sidecar selector as it has changed from app: prometheus to app.kubernetes.io/name: prometheus. This chart should be able to deal with both variances and the sidecar.selector value is now required.

fixes #1261

Why?

app label was removed from prometheus -> https://github.com/prometheus-operator/prometheus-operator/pull/4350.

Additional context

Tested locally

maciekm commented 3 years ago

1262 looks approved - the only objection is that it hardcodes the new label.