banzaicloud / banzai-charts

Curated list of Banzai Cloud Helm charts used by the Pipeline Platform
Apache License 2.0
367 stars 278 forks source link

GrafanaDashboards won't deploy due to missing property #1311

Open rbs4ba opened 2 years ago

rbs4ba commented 2 years ago

Describe the bug In a previous change you removed the name config: https://github.com/banzaicloud/banzai-charts/commit/b062e9be332829b6ff1cbf4fa2a404bb9873fe4c#diff-a18e8cac40ab6b4391f471403ea8809157013d843847ecbd4d170cc045efe6ebL21 when accidentally updating the CRD. When you reverted the change, you did not re-add the name config: https://github.com/banzaicloud/banzai-charts/commit/73b26a42fdbc48c06681e4cabbe940832cb8294d#diff-5689f1966f7e00acd0cdcff38ae0fc49d66469b384af9139412d645439937c2d

This results in all of the default dashboards, as well other custom dashboards failing to deploy because the new CRD does not recognize the old name property

Steps to reproduce the issue: Install the chart with the latest CRD and deploy the default dashboards

Expected behavior Dashboards should install successfully

Screenshots N/A

Additional context N/A