search

banzaicloud / banzai-charts

Curated list of Banzai Cloud Helm charts used by the Pipeline Platform
Apache License 2.0
368 stars 285 forks source link

[cadence] only requires frontend in bootstrap to reduce startup friction #1313

Open longquanzheng opened 2 years ago

longquanzheng commented 2 years ago

https://github.com/banzaicloud/banzai-charts/blob/4d51cb1645d9bceb07e209f121e37b165c92910a/cadence/templates/server-configmap.yaml#L74

also change default number of frontend to 2.

see https://uber-cadence.slack.com/archives/CM4K75Y7R/p1639081204013600

pregnor commented 2 years ago

Hey @longquanzheng,

Thanks for the report.

Could you clarify the expectation here? Because it is not clear to us what to do.

Should we raise the replica count of the frontend service to 2? And how is it related to the bootstrap hosts?

(Apologies, I'm a bit out of context here, checked the server config, but could not figure it out.)

longquanzheng commented 2 years ago

Yes, raise the frontend count to 2 and only use frontend for bootstrap. Leave a comment to tell people to use at least two hosts for frontend.

The reason is that ringpop requires at least seeing another hosts during startup.

Using frontend only for bootstrap is better because frontend doesn’t need to connect to database during startup (stateless).

While I am writing this I think maybe using frontend and worker for startup is even better because it’s also stateless. And if so we don’t need to change replicaCount of frontend.

On Fri, Jan 14, 2022 at 1:09 AM Patrik Egyed @.***> wrote:

Hey @longquanzheng https://github.com/longquanzheng,

Thanks for the report.

Could you clarify the expectation here? Because it is not clear to us what to do.

Should we raise the replica count of the frontend service to 2? And how is it related to the bootstrap hosts?

(Apologies, I'm a bit out of context here, checked the server config, but could not figure it out.)

— Reply to this email directly, view it on GitHub https://github.com/banzaicloud/banzai-charts/issues/1313#issuecomment-1012936889, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCQPM4WIHDYXBKDEWQXAQTUV7R3TANCNFSM5JXXKXSQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

--

Thanks, Quanzheng