search

banzaicloud / banzai-charts

Curated list of Banzai Cloud Helm charts used by the Pipeline Platform
Apache License 2.0
367 stars 278 forks source link

Update servicemonitor with right service labels #1314

Closed ashwinrajadurai3 closed 2 years ago

ashwinrajadurai3 commented 2 years ago
Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets nil
License Apache 2.0

What's in this PR?

Bug fix, service monitor label is not matching service label hence fixing it

Why?

Bug fix, service monitor label is not matching service label hence fixing it

Checklist

ashwinrajadurai3 commented 2 years ago

Please merge this PR @pepov @pregnor This is in-reference to https://github.com/banzaicloud/banzai-charts/pull/1271 which has a minor correction causing implementation failure which i modified here. Kindly do the needful

ashwinrajadurai3 commented 2 years ago

Thankyou @pregnor, can i please get another approval to merge this PR @pepov @ahma @tarokkk @mpritter76 @swirsky

ahma commented 2 years ago

@ashwinrajadurai3 Thanks for the contribution, please bump the version as well.

ashwinrajadurai3 commented 2 years ago

@ashwinrajadurai3 Thanks for the contribution, please bump the version as well.

Bumped the version @ahma Please merge the PR now, Thanks!

ashwinrajadurai3 commented 2 years ago

@ashwinrajadurai3 Thanks for the contribution, please bump the version as well.

Bumped the version @ahma Please merge the PR now, Thanks!

Please do the needful here @ahma @pregnor

pregnor commented 2 years ago

Merged and released a corresponding tag chart/spot-termination-exporter/0.0.11