search

banzaicloud / banzai-charts

Curated list of Banzai Cloud Helm charts used by the Pipeline Platform
Apache License 2.0
367 stars 278 forks source link

cadence: allow existingSecret to be used in schema setup #1328

Closed mrd000 closed 1 year ago

mrd000 commented 1 year ago
Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets none found
License Apache 2.0

What's in this PR?

This PR makes cadence schema setup part of the helm chart work when a database password is only stored as a k8s secret via existingSecret parameter and not supplied via the password parameter. It currently works with schema setup/update being off. (schema/setup/enabled: false and schema/update/enabled: false.

Why?

This PR tries to fix the inconsistency of the chart behaviour. At the moment existingSecret would only work alone if the schema setup/update is not enabled. Once it's enabled there is an error reported by helm requiring the password being explicitly given to the chart as a value.

Additional context

The change was tested on my test k8s setup.

Checklist

akijakya commented 1 year ago

Tested, didn't experience any issues, however @mrd000 please also bump the chart patch version to 0.24.1!

mrd000 commented 1 year ago

Tested, didn't experience any issues, however @mrd000 please also bump the chart patch version to 0.24.1!

Done! I did not realise I'd need to do that, sorry.

akijakya commented 1 year ago

Tested, didn't experience any issues, however @mrd000 please also bump the chart patch version to 0.24.1!

Done! I did not realise I'd need to do that, sorry.

NP 🙂