search

banzaicloud / banzai-charts

Curated list of Banzai Cloud Helm charts used by the Pipeline Platform
Apache License 2.0
367 stars 278 forks source link

thanos: error: unknown long flag '--block-sync-concurrency' #1341

Open NFarrington opened 1 year ago

NFarrington commented 1 year ago

Describe the bug

The flag --block-sync-concurrency was removed from Thanos compactor in v0.27.0 onwards - https://github.com/thanos-io/thanos/blob/main/CHANGELOG.md#v0270---20220705

Steps to reproduce the issue:

  1. Deploy v0.4.6 of the Thanos chart with Thanos v0.27.0 or greater (Values.image.tag: v0.27.0).
  2. Wait for the Thanos compactor pod to fail to start.
  3. Observe the following error in the pod logs: thanos: error: unknown long flag '--block-sync-concurrency'

Expected behavior

The --block-sync-concurrency flag is not used, and the compactor pod starts successfully.

Additional context

https://github.com/banzaicloud/banzai-charts/blob/1612d5117eae5fc5d3dd04304695d6951d8f39c0/thanos/templates/compact-deployment.yaml#L62