search

banzaicloud / istio-operator

An operator that manages Istio deployments on Kubernetes
Apache License 2.0
535 stars 94 forks source link

Fix crd delete func predicate logic #792

Closed panyuenlau closed 3 years ago

panyuenlau commented 3 years ago
Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

If the CRD is not owned by our istio-operator, the deletion of the CRD shouldn't trigger the reconcile logic

Why?

The original implementation would try to create the deleted istio CRDs even they are not managed by us

Additional context

Checklist

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.