banzaicloud / istio-operator

An operator that manages Istio deployments on Kubernetes
Apache License 2.0
535 stars 94 forks source link

[v2] add custom patch maker for proto based api #838

Closed waynz0r closed 2 years ago

waynz0r commented 2 years ago
Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets
License Apache 2.0

What's in this PR?

Adds a custom patch maker for k8s object matching library to support Istio proto based api/resources.

Why?

There is an issue using the default patch maker in the k8s object matcher library with proto based Istio api/resources. This is mainly, because there is a discrepancy between the field names in json and proto tags for some fields and that causes issue with the upstream k8s strategic merge patcher library field detection.

Checklist