banzaicloud / koperator

Oh no! Yet another Apache Kafka operator for Kubernetes
Apache License 2.0
789 stars 198 forks source link

Move Helm chart CRDs to a dedicated folder #1047

Closed rappizs closed 1 year ago

rappizs commented 1 year ago

Description:

Fixes https://github.com/banzaicloud/koperator/issues/1034

Solution details: https://helm.sh/docs/chart_best_practices/custom_resource_definitions/#method-1-let-helm-do-it-for-you Note that CRDs will be installed by default, it can be turned off with the --skip-crds flag for helm install.

Type of Change

Checklist

rappizs commented 1 year ago

please double check the release CI to be able to work with the modifications

Works fine, it uses the manifests from config/base/crds.

rappizs commented 1 year ago

We might also want to remove the deprecated value (crd.enabled) from the e2e test

Done, thanks for catching this! Also removed crd.enabled from the docs.