banzaicloud / pipeline

Banzai Cloud Pipeline is a solution-oriented application platform which allows enterprises to develop, deploy and securely scale container-based applications in multi- and hybrid-cloud environments.
https://banzaicloud.com/products/pipeline/
Apache License 2.0
1.5k stars 163 forks source link

Force delete on cluster in deleting status #3616

Closed akijakya closed 2 years ago

akijakya commented 2 years ago
Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

Made force delete work on clusters already in deleting status.

Why?

If a cluster stuck in deleting status according to the database (even though its resources were terminated), there was no way to make it disappear from the client side.

Additional context

Tested locally. If a force delete is called on a cluster with a running deletion workflow still unfinished, the second workflow failed but the resources were terminated and the database was updated successfully (tested with PKE on AWS).

Checklist