search

banzaicloud / pipeline

Banzai Cloud Pipeline is a solution-oriented application platform which allows enterprises to develop, deploy and securely scale container-based applications in multi- and hybrid-cloud environments.
https://banzaicloud.com/products/pipeline/
Apache License 2.0
1.5k stars 163 forks source link

Updated EKS kubeconfig auth apiversion #3623

Closed akijakya closed 2 years ago

akijakya commented 2 years ago
Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? yes
Related tickets -
License Apache 2.0

What's in this PR?

Updated EKS kubeconfig auth apiversion client.authentication.k8s.io/v1alpha1 -> client.authentication.k8s.io/v1beta1, which is returned e.g. as a result of the banzai cli command banzai cluster shell.

Why?

In kubernetes and kubectl version 1.24 the client.authentication.k8s.io/v1alpha1 apiversion has been deprecated.

Additional context

Tested locally. Tested also with kubectl version 1.22 and found no issues either.

Checklist

pregnor commented 2 years ago

Might cause break if lower kubectl version is used.

I'm thinking about possible alternatives here.

Can't we work around this in banzai-cli? Checking whether the kubectl version is older and writing it back or something? We haven't had many reports regarding 1.24 beta failures so it might be best not to break older kubectl versions.

akijakya commented 2 years ago

Can't we work around this in banzai-cli? Checking whether the kubectl version is older and writing it back or something? We haven't had many reports regarding 1.24 beta failures so it might be best not to break older kubectl versions.

I managed to test it with kubectl version 1.22 as well and found no issues running kubectl commands after a banzai cluster shell!