Updated golangci-lint version 1.30.0->1.50.0 - Githubissues

banzaicloud / pipeline

Banzai Cloud Pipeline is a solution-oriented application platform which allows enterprises to develop, deploy and securely scale container-based applications in multi- and hybrid-cloud environments.

https://banzaicloud.com/products/pipeline/

Apache License 2.0

1.5k stars 163 forks source link

Updated golangci-lint version 1.30.0->1.50.0 #3650

Closed akijakya closed 1 year ago

akijakya commented 1 year ago

Q	A
Bug fix?	no
New feature?	no
API breaks?	no
Deprecations?	no
Related tickets	-
License	Apache 2.0

What's in this PR?

Updated golangci-lint to latest version (1.30.0->1.50.0).

Why?

So we use a version that has build for darwin/arm64 systems for local linting.

Additional context

There were a lot of linting errors initially, as a lot of new linters and linter updates have been introduced since the previous versions we used.

Followed strategy:

if a linter was existing in the time of the previously used linter version (1.30.0), errors were fixed
if a linter was deprecated, the linter was disabled and removed in code
if a linter was newly introduced, it was disabled for now.

Checklist

[X] Implementation tested (with at least one cloud provider)
[X] Code meets the Developer Guide
~OpenAPI and Postman files updated (if needed)~
~User guide and development docs updated (if needed)~
~Related Helm chart(s) updated (if needed)~