search

banzaicloud / spot-termination-exporter

Prometheus spot instance exporter to monitor AWS instance termination with Hollowtrees
Apache License 2.0
36 stars 16 forks source link

Missing support for annotation + nodeselector issue #16

Open eliorso opened 2 years ago

eliorso commented 2 years ago

The currect daemonset.yaml does support adding of Annotations.

I had to update the file as follow: {{- with .Values.Annotations }} annotations: {{ toYaml . | nindent 8 }} {{- end }}

Another bug that i found when using node selector, the useHostNetwork failed, fixed by : {{ toYaml .Values.resources | indent 10 }} hostNetwork: {{ .Values.useHostNetwork }} {{- with .Values.nodeSelector }} nodeSelector: {{ toYaml . | indent 8 }} {{- end }}

danielmotaleite commented 10 months ago

i fixed the nodeSelector like this, as the main issue is the different scope inside the nodeSelector step

{{ toYaml .Values.resources | indent 10 }}
{{- $hostnetwork := .Values.useHostNetwork }}
    {{- with .Values.nodeSelector }}
      hostNetwork: {{ $hostnetwork }}
      nodeSelector: