search

bao-project / bao-demos

A guide on how to build and use a set of Bao guest configurations for various platforms
Other
33 stars 37 forks source link

Faile to make clean #29

Closed tupelo-shen closed 1 year ago

tupelo-shen commented 1 year ago

it seems to be that the rule of clean target is incorrect in Makefile of top directory of bao-demos project. The code snip is as follows:

clean: guests_clean bao_clean platform_clean
    -rm -rf $(wrkdir)/imgs/$(PLAT)/$(DEMO)

If execute make PLATFORM=xxxx DEMO=yyyy clean command, the result is:

rm -rf /PATH-TO-PROJECT/bao-demos/wrkdir/imgs//linux+freertos

There is nothing between the subdirectory /imgs/ and linux+freertos. So, I think of PLAT variable should be replaced with PLATFORM. Like as follows:

clean: guests_clean bao_clean platform_clean
    -rm -rf $(wrkdir)/imgs/$(PLATFORM)/$(DEMO)
josecm commented 1 year ago

thanks for catching this @tupelo-shen

Just fixed it in 03cd073. If possible, next time please just send us a PR with the proposed fix!