Taping outside of navigation doesn't close it on Frame component

baoagency / polaris_view_components

ViewComponents for Polaris Design System

https://polarisviewcomponents.org

MIT License

380 stars 53 forks source link

Closed remy727 closed 3 months ago

remy727 commented 4 months ago

On Frame component, navigation menu is not being closed when clicking outside of navigation. You can try here on mobile.

I confirmed Shopify Frame component supports this.

kirillplatonov commented 4 months ago

Please open a PR for that.

remy727 commented 4 months ago

Yes. I want to work on this but I am not sure where requires the changes? Can you guide me how I can accomplish this?

kirillplatonov commented 4 months ago

Check out source code of FrameComponents class and views. You might need to add custom JS/CSS to Polaris ViewComponents for this feature.

remy727 commented 3 months ago

@kirillplatonov, I created #426. It was simpler than I thought.