I noticed that when using a block on the FormBuilder#polaris_text_field (eg: to add connected fields), the block wasn't correctly passed to Polaris::TextFieldComponent.new and the final render wasn't complete.
I added tests to cover the issue, but i'm not 100% confident on the change and i wish i could get a code review.
Also, i'm unsure if other methods sharing the same pattern are actually suffering the same issue. If yes i can fix all of them and add tests.
I noticed that when using a block on the
FormBuilder#polaris_text_field
(eg: to add connected fields), the block wasn't correctly passed toPolaris::TextFieldComponent.new
and the final render wasn't complete.I added tests to cover the issue, but i'm not 100% confident on the change and i wish i could get a code review. Also, i'm unsure if other methods sharing the same pattern are actually suffering the same issue. If yes i can fix all of them and add tests.
Thanks for your help!