search

baobaoit / Asus-ROG-GL552VW-OC

Hackintosh Asus GL552VW with Open Core
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

Convert static patched (DSDT patched) to hotpatch (SSDT patched) #12

Open baobaoit opened 3 years ago

baobaoit commented 3 years ago

Common patches

victorwitkamp commented 3 years ago

Made a battery hotpatch using rehabman's guide (https://www.tonymacx86.com/threads/guide-using-clover-to-hotpatch-acpi.200137/) which could replace the "[bat] ASUS G75VW" DSDT patch and does the following for GL552VW:

SSDT-BAT.dsl.txt

Hope that it is of any use.

baobaoit commented 3 years ago

Hi @victorwitkamp,

About battery patch "[bat] ASUS G752VW", it already handled by VirtualSMC and SMCBatteryManager.

Currently, I'm stuck at the I2C controller patching. I'm not figuring out how to make it as hot patching. I will re-work when I have free time, or I can find any documents that helpful.

Thank you and appreciate your work.

victorwitkamp commented 3 years ago

Hi @victorwitkamp,

About battery patch "[bat] ASUS G752VW", it already handled by VirtualSMC and SMCBatteryManager.

Currently, I'm stuck at the I2C controller patching. I'm not figuring out how to make it as hot patching. I will re-work when I have free time, or I can find any documents that helpful.

Thank you and appreciate your work.

I've read on the VoodooI2C Gitter that battery patch is required for VoodooI2C to work. And when I tried to get VoodooI2C working in OpenCore using DSDT patching it indeed started working after applying the battery fix. So I'm kind of confused now wether it is required or not.

Anyway, I've done some work for the I2C controller. If I'm correct USTP should enable the I2C controller, but I did not get it working completely yet using hotpatching (which could be caused by the battery patch)

SSDT-ETPD.dsl.txt

I still need to do the USTP to XSTP rename, but here is the ETPD _CRS TO XCRS:

    <dict>
        <key>Comment</key>
        <string>GPIO pinning - _CRS to XCRS in ETPD in DSDT</string>
        <key>Count</key>
        <integer>1</integer>
        <key>Enabled</key>
        <true/>
        <key>Find</key>
        <data>FBFfQ1JTAA==</data>
        <key>Limit</key>
        <integer>0</integer>
        <key>Mask</key>
        <data></data>
        <key>OemTableId</key>
        <data></data>
        <key>Replace</key>
        <data>FBFYQ1JTAA==</data>
        <key>ReplaceMask</key>
        <data></data>
        <key>Skip</key>
        <integer>0</integer>
        <key>TableLength</key>
        <integer>0</integer>
        <key>TableSignature</key>
        <data>RFNEVA==</data>
    </dict>
baobaoit commented 3 years ago

Hi @victorwitkamp,

I had tried your SSDT files, my case is:

Booting up fine. But the trackpad is not working.

I know the hot patching for trackpad on SkyLake chipset is very hard and I appreciate your research.

If there is anything new, let me know, I will test it on weekend.

Thank you.

victorwitkamp commented 3 years ago

Hi @victorwitkamp,

I had tried your SSDT files, my case is:

  • Using 2 SSDTs that provided
  • I added 2 ACPI patches: Rename USTP to XSTP and your patch

Booting up fine. But the trackpad is not working.

I know the hot patching for trackpad on SkyLake chipset is very hard and I appreciate your research.

If there is anything new, let me know, I will test it on weekend.

Thank you.

Can you tell me what you were seeing in the logging? Any specific messages from VoodooI2C? Perhaps "Unknown Synopsys component type: 0xffffffff"

baobaoit commented 3 years ago

Hi @victorwitkamp,

I didn't see any messages.

Thank you.

fsdevriver commented 3 years ago

Is there any update about hotpaching I2C?

baobaoit commented 3 years ago

Is there any update about hotpaching I2C?

Temporarily is no, there is no technical or document about this. For the Skylake chip, you need to do static patch.

fsdevriver commented 3 years ago

Is there any update about hotpaching I2C?

Temporarily is no, there is no technical or document about this. For the Skylake chip, you need to do static patch.

Does that mean add patched DSDT in ACPI?

baobaoit commented 3 years ago

Is there any update about hotpaching I2C?

Temporarily is no, there is no technical or document about this. For the Skylake chip, you need to do static patch.

Does that mean add patched DSDT in ACPI?

Yes, to have a full functionality, you need to patch DSDT and place it in ACPI.

fsdevriver commented 3 years ago

I tried for several months but failed. Brother could you please help me to patching DSDT? Just skylake patching part. Here is my dump ACPI folder https://drive.google.com/file/d/1SjWYapMc3-E86hUVuQ0k4ODZNAlmamql/view?usp=sharing

baobaoit commented 3 years ago

I tried for several months but failed. Brother could you please help me to patching DSDT? Just skylake patching part. Here is my dump ACPI folder https://drive.google.com/file/d/1SjWYapMc3-E86hUVuQ0k4ODZNAlmamql/view?usp=sharing

Sorry, I'm busy now. I didn't know so much about this. I just research my model. You can find some help on the Olarila forum.

valerieapps commented 3 years ago

hello, I want to use this to install Catalina on my gl552vw. can you tell me what's currently not working? thank you very much

baobaoit commented 3 years ago

hello, I want to use this to install Catalina on my gl552vw. can you tell me what's currently not working? thank you very much

The card reader + NVIDIA card are not working. HDMI not tested. Jack 3.5mm not tested.

Please update to the latest OC and kexts version to have a better experiment.

valerieapps commented 3 years ago

hello, I want to use this to install Catalina on my gl552vw. can you tell me what's currently not working? thank you very much

The card reader + NVIDIA card are not working. HDMI not tested. Jack 3.5mm not tested.

Please update to the latest OC and kexts version to have a better experiment.

hello, just reporting back. i finally got around to install catalina. i used this OC exactly as it is and didn't update anything, it worked amazing from the first try. the only thing that didn't work was usb 3 ports but i noticed usbinjectall,kext was disabled by default so i enabled it and they all woked perfectly, managed to get my intel wifi to work too. thank you very much for making this repo 😁👍

victorwitkamp commented 2 years ago

Took a while, but still wanted to let you know... I got my trackpad working on my GL552VW using hotpatching! Only polling mode currently, but getting somewhere. https://github.com/victorwitkamp/GL552VW-OpenCore

valerieapps commented 2 years ago

Took a while, but still wanted to let you know... I got my trackpad working on my GL552VW using hotpatching! Only polling mode currently, but getting somewhere. https://github.com/victorwitkamp/GL552VW-OpenCore

Hi bro, are you using catalina? im currently on catalina and want to upgrade to big sur directly from app store, can i do it without changing anything in this repo? thanks

victorwitkamp commented 2 years ago

Took a while, but still wanted to let you know... I got my trackpad working on my GL552VW using hotpatching! Only polling mode currently, but getting somewhere. https://github.com/victorwitkamp/GL552VW-OpenCore

Hi bro, are you using catalina? im currently on catalina and want to upgrade to big sur directly from app store, can i do it without changing anything in this repo? thanks Screenshot 2022-01-23 at 10 00 52

victorwitkamp commented 2 years ago

(I did not test upgrading, Did a fresh Monterey install)

valerieapps commented 2 years ago

(I did not test upgrading, Did a fresh Monterey install)

thats awesome dude, can you please chare your OC folder? i'd appreciate it very much

victorwitkamp commented 2 years ago

That's the same link: https://github.com/victorwitkamp/GL552VW-OpenCore

valerieapps commented 2 years ago

that's awesome thanks a lot. really got me out of a pinch. i needed to use a more recent version of xcode urgently

victorwitkamp commented 2 years ago

You can use macrecovery to download Monterey. https://dortania.github.io/OpenCore-Install-Guide/installer-guide/winblows-install.html#downloading-macos

valerieapps commented 2 years ago

is it possible to replace my current OC folder (catalina) with yours and then attempt to update to monterey from system update? would it work?

victorwitkamp commented 2 years ago

I can't guarantee anything, but definitely worth trying. As long as you make a backup of your current OC folder.

valerieapps commented 2 years ago

Hi victor, so i finally decided to do a clean install of monterey, i created the usb and copied your OC folder exactly like it is, i can boot into open core but i choose "install macOS Monterey" i get stuck in this screen immediately. any idea why this is happening? thanks a lotv unnamed EDIT: I fixed it by disabling CFG Lock. i didn't know that was required. Everything working fine including wifi with heliport. sorry to bother you and thanks again for the great repo 😍

victorwitkamp commented 2 years ago

Hi victor, so i finally decided to do a clean install of monterey, i created the usb and copied your OC folder exactly like it is, i can boot into open core but i choose "install macOS Monterey" i get stuck in this screen immediately. any idea why this is happening? thanks a lotv unnamed EDIT: I fixed it by disabled CFG Lock. i didn't know that was required. Everything working fine including wifi with heliport. sorry to bother you and thanks again for the great repo 😍

Congrats!!!! And any time!! Did you have an option for CFG lock in the BIOS? Or managed to unlock it a different way? I didn't have a CFG Lock option in my BIOS, which is why I'm curious.

valerieapps commented 2 years ago

i simply used the "CFGLock" option in the opencore boot menu that you made. I didnt have it in my BIOS.