search

baoyachi / shadow-rs

A build-time information stored in your rust project.(binary,lib,cdylib,dylib)
https://docs.rs/shadow-rs
MIT License
475 stars 41 forks source link

fix warnings please #47

Closed fdncred closed 3 years ago

fdncred commented 3 years ago

Hey @baoyachi, Would you mind fixing these warnings so we can build without warnings in nushell?

warning: function is never used: `version`
   --> /home/folder/src/forks/nushell/target/release/build/nu-command-907562c9e57f4e61/out/shadow.rs:681:8    |
681 | pub fn version() -> String {
    |        ^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

warning: function is never used: `clap_version`
   --> /home/folder/src/forks/nushell/target/release/build/nu-command-907562c9e57f4e61/out/shadow.rs:692:8    |
692 | pub fn clap_version() -> String {
    |        ^^^^^^^^^^^^
baoyachi commented 3 years ago

Sorry. I fix this warning now.

baoyachi commented 3 years ago

It's solved with nushell by link: https://github.com/nushell/nushell/pull/2960. Thanks for report .

fdncred commented 3 years ago

thank you for responding so fast. :)