search

baptistebriel / smooth-scrolling

smooth scrolling and parallax effects on scroll
MIT License
612 stars 75 forks source link

Empty space after content with native: true #81

Open woowski opened 6 years ago

woowski commented 6 years ago

Hey @baptistebriel, it's me again šŸ˜

I ran into another issue...

I've tried to set up my smooth scroll with native: true to enjoy the is-scrolling feature which is added to the listener when doing so. Except now, even though i'm able to scroll, it's causing my page to be way higher than it's suppose to, "adding" a large blank space after my content. If i put native back to false, there's no problem whatsoever.

My scroll section is the right size according to the inspector...

Do you know what might be causing the issue ?

Thanks (once again), hope i'm not asking to much.

You can find the example here : https://pensive-lichterman-1038a1.netlify.com

ps : i'm using biggie to set up all this, i don't think it's related to this. But if you want to look at the home.js file, you know where to find it. šŸ˜‰

Let me know if i'm asking to much, i'm pretty new to all this stuff, doing my best trying to figure it out on my own, but sometimes i have no clue of what might be happening, and it could simple be a misconfiguration.

cheers

baptistebriel commented 6 years ago

Hey @woowski, First of all I think you need to apply this CSS to the .uscrollmofo element:

.uscrollmofo {
  position: absolute;
  top: 0; left: 0;
}

I believe the blank space is because of the .vs-scroll-view being after the .uscrollmofo section. Also, could you share the resize function code if you're extending Smooth? If you're using the default class, it should already work as expected. You can also compare the CSS of this demo with yours.

Let me know!

woowski commented 6 years ago

Hey @baptistebriel

Thanks again for your answer, but whatever i do i'm running into many issues trying to get smooth-scrolling working properly, native or not, i'm running into browser inconsistency, bad height calculation and many other and i don't want to create a new issue everytime.

I'm not even talking about trying to get it working with a masonry grid, as i'm having height problem whatever the way i'm trying to implement smooth-scrolling...

I think i'll stick without it right now, will get to it later, when i'll have more time trying to get it working.

Thanks again for your time and availability, deeply appreciate it.

cheers mate !

baptistebriel commented 6 years ago

Hey @woowski, I hope you managed to do what you want! Since I'm not sure if there is an actual bug in the code, would you mind closing this issue? Otherwise feel free to let me know!