barahona-research-group / PyGenStability

PyGenStability: Multiscale community detection with generalized Markov Stability
https://barahona-research-group.github.io/PyGenStability/
GNU General Public License v3.0
32 stars 11 forks source link

Preloop for constructors #51

Closed d-schindler closed 2 years ago

d-schindler commented 2 years ago

I've implemented a preloop that computes constructors for all Markov scales in a parallelised way and stores them for later use. I hope this speeds up the process because computing the constructors is the bottleneck of MS analysis, which was previously not parallelised. The implementation seems to work but speed increase needs to be checked.

codecov-commenter commented 2 years ago

Codecov Report

Merging #51 (845148d) into master (f00fd8e) will decrease coverage by 2.45%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   41.85%   39.40%   -2.46%     
==========================================
  Files           8        8              
  Lines         571      571              
==========================================
- Hits          239      225      -14     
- Misses        332      346      +14     
Flag Coverage Δ
pytest 39.40% <100.00%> (-2.46%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pygenstability/constructors.py 89.74% <100.00%> (-0.86%) :arrow_down:
src/pygenstability/pygenstability.py 80.62% <100.00%> (-10.08%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

d-schindler commented 2 years ago

The implementation of the pre-loop is completed, should we merge into master? I guess some of the checks fail because of code syntax..

arnaudon commented 2 years ago

thank a lot, I'll take a look and merge it asap!