barahona-research-group / PyGenStability

PyGenStability: Multiscale community detection with generalized Markov Stability
https://barahona-research-group.github.io/PyGenStability/
GNU General Public License v3.0
32 stars 11 forks source link

Update documentation #57

Closed d-schindler closed 2 years ago

d-schindler commented 2 years ago

This PR is to update the documentation including the README

codecov-commenter commented 2 years ago

Codecov Report

Merging #57 (764b2f9) into master (403e461) will not change coverage. The diff coverage is 26.31%.

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   48.21%   48.21%           
=======================================
  Files           8        8           
  Lines         589      589           
=======================================
  Hits          284      284           
  Misses        305      305           
Flag Coverage Δ
pytest 48.21% <26.31%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pygenstability/plotting.py 0.00% <0.00%> (ø)
src/pygenstability/optimal_scales.py 100.00% <100.00%> (ø)
src/pygenstability/pygenstability.py 96.24% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

peach-lucien commented 2 years ago

the readme still needs the references added before merging into master I believe? or remove them from the text.

d-schindler commented 2 years ago

I added the references and code snippets for specifying Leiden and plotting optimal partitions in the workflow

d-schindler commented 2 years ago

I also changed all "vi" and "variation_information" to NVI

arnaudon commented 2 years ago

ok, this looks good, thanks! I'll clean it up and merge

d-schindler commented 2 years ago

I copied the text for the licence from Leiden Repo, not sure if this is ok

arnaudon commented 2 years ago

Thanks, yes, licence should be fine!