barahona-research-group / PyGenStability

PyGenStability: Multiscale community detection with generalized Markov Stability
https://barahona-research-group.github.io/PyGenStability/
GNU General Public License v3.0
32 stars 11 forks source link

Add more examples #60

Closed arnaudon closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Merging #60 (2cb41d3) into master (e54790f) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #60   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          532       532           
=========================================
  Hits           532       532           
Flag Coverage Δ
pytest 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

arnaudon commented 1 year ago

Just need to add leiden tests to increase cov back to 100 once leiden PR is merged/released

d-schindler commented 1 year ago

I used this branch to make a small change for the plotting: I discovered that we often have white regions on the diagonal of the NVI(t,t^\prime) heatmap when the NVI is 0 but actually it should be dark in our colour scheme, so I changed the "extend" of the contour plot to "min".

arnaudon commented 1 year ago

It's better to make new branch, but this is small, so it's fine

arnaudon commented 1 year ago

ah sorry, I thought this was leiden branch, it's fine here indeed! Feel free to improve stuff here as well!

peach-lucien commented 1 year ago

did we decide on whether we want to merge these examples into main? They are not quick to compute despite my best efforts to compressing them considerably. If so, we will want to add these examples into the docs.

d-schindler commented 1 year ago

I thought we wanted to pre-compute the examples, and provide the results as files that are then just read in the notebooks?