Closed d-schindler closed 1 year ago
We need to set $\alpha=1$ (no teleportation) as a default for large graphs because otherwise the quality functions is a dense matrix, which leads to memory errors.
We should have constructors_kwargs
as an argument in run()
such that one can change teleportation conveniently.
I think we need to improve the code for constructors by using more scipy.sparse
commands.
@arnaudon , I think this is ready to merge after your improvements. could you e.g. provide a kwarg in run to set the teleportation parameter alpha?
Merging #70 (3554cfe) into master (33890b7) will not change coverage. The diff coverage is
100.00%
.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## master #70 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 552 576 +24
=========================================
+ Hits 552 576 +24
Flag | Coverage Δ | |
---|---|---|
pytest | 100.00% <100.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
src/pygenstability/constructors.py | 100.00% <100.00%> (ø) |
|
src/pygenstability/pygenstability.py | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Here you are!
Let me know if it's ok, and we can merge!
Do you keep the print statements on purpose? Also the print("alpha1")
?
Oups, I just removed them!
is it good to merge like that @d-schindler ?
Yes, I think it's fine now!
Before you merge, could you delete this from benchmarking.py, it's deprecated: with_spectral_decomp=True
This PR is to provide linearized MS for directed networks as discussed in #69