search

barakagb / gb-dl

A python based utility to download courses from infosec4tc.teachable.com , academy.ehacking.net and stackskills.com for personal offline use.
https://pypi.org/project/gb-dl/
MIT License
39 stars 14 forks source link

Problems with "Sanitizing file names ..." #35

Closed RobinE closed 4 years ago

RobinE commented 4 years ago

GB-DL Downloaded a large number of folders and videos from: stackskills.com/courses/enrolled/623434 into home directory under MacOS. After the message on terminal "Sanitizing file names ..." things went quiet for a very long time. Activity Monitor showed Python at 100% CPU, but nothing happening to rename the downloaded .bin files as .mp4. After 30+ mins (ever hopeful), terminated the terminal session and used utilities to manually rename the 100+ files. They all seem to be the expected downloads. Tried to take a quick look at the gb-dl.py file, but not familiar enough (yet) to understand what's not working in the sanitize function. P.S. using the 1.6.7 version of gb-dl from PyPi under Python 3.8.5

barakagb commented 4 years ago

Noted . I have not tried the script on a mac before. But i will work on it and revert back to you soon.

On Sat, Oct 24, 2020, 22:02 RobinE notifications@github.com wrote:

GB-DL Downloaded a large number of folders and videos from: stackskills.com/courses/enrolled/623434 into home directory under MacOS. After the message on terminal "Sanitizing file names ..." things went quiet for a very long time. Activity Monitor showed Python3.7 at 100% CPU, but nothing happening to rename the downloaded .bin files as .mp4. After 30+ mins (ever hopeful) I terminated the terminal session and had to use utilities to manually rename 100+ files. They all seem to be the expected downloads. Tried to take a quick look at the gb-dl.py file, but not familiar enough (yet) to understand what's not working in the sanitize function. P.S. using the 1.6.7 version of gb-dl from PyPi under Python 3.8.5

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/barakagb/gb-dl/issues/35, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJTRBPQLDT3IYPKCOPEP63SMMQDTANCNFSM4S5YX4KQ .

RobinE commented 4 years ago

No rush! I was able to DL the files for offline viewing. A very useful utility

On Sat, Oct 24, 2020 at 8:17 PM barakagb notifications@github.com wrote:

Noted . I have not tried the script on a mac before. But i will work on it and revert back to you soon.

On Sat, Oct 24, 2020, 22:02 RobinE notifications@github.com wrote:

GB-DL Downloaded a large number of folders and videos from: stackskills.com/courses/enrolled/623434 into home directory under MacOS. After the message on terminal "Sanitizing file names ..." things went quiet for a very long time. Activity Monitor showed Python3.7 at 100% CPU, but nothing happening to rename the downloaded .bin files as .mp4. After 30+ mins (ever hopeful) I terminated the terminal session and had to use utilities to manually rename 100+ files. They all seem to be the expected downloads. Tried to take a quick look at the gb-dl.py file, but not familiar enough (yet) to understand what's not working in the sanitize function. P.S. using the 1.6.7 version of gb-dl from PyPi under Python 3.8.5

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/barakagb/gb-dl/issues/35, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AHJTRBPQLDT3IYPKCOPEP63SMMQDTANCNFSM4S5YX4KQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/barakagb/gb-dl/issues/35#issuecomment-716042238, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC4XEGC2ZJAY7Z3YD5NKQTSMMR55ANCNFSM4S5YX4KQ .

RobinE commented 4 years ago

I've experimented with the "sanitize_file_names" function in gb-dl.py Something along the lines of the attached function works as expected. This version is a useful hack for changing file extensions. I've no idea why the original function seemed to hang... What did the try/except in the original aim to do? test.py.txt

barakagb commented 4 years ago

Thanks @RobinE for the feedback . Will try and experiment and upload a revised version. Cheers!

barakagb commented 4 years ago

Hi @RobinE , sorry for late feedback I had no access to a computer. I've done some experimenting and noted that sanitation was only done in sub-folders hence if files where in the main course folder they wouldn't be sanitized.

I made a fix and now every thing should work correctly . Kindly upgrade to v1.6.8 using pip install gb-dl -U Cheers!

RobinE commented 4 years ago

Ca marche! Merci beaucoup.