barakagb / gb-dl

A python based utility to download courses from infosec4tc.teachable.com , academy.ehacking.net and stackskills.com for personal offline use.
https://pypi.org/project/gb-dl/
MIT License
39 stars 14 forks source link

Source code missing #36

Closed berndverst closed 4 years ago

berndverst commented 4 years ago

Where is your source code?

I want to inspect the code to ensure it does not send data to third party services.

berndverst commented 4 years ago

Ah I see - you were using youtube-dl!

Well it is safe to put the code out again.

https://www.eff.org/deeplinks/2020/11/github-reinstates-youtube-dl-after-riaas-abuse-dmca

barakagb commented 4 years ago

Hi there , the script doesn't send data to third parties . You can download the script using pip install gb-dl and get a key after donating to buymeacoff.ee/barakagb .

Thanks.

On Mon, Nov 23, 2020, 21:06 Bernd Verst notifications@github.com wrote:

Ah I see - you were using youtube-dl!

Well it is safe to put the code out again.

https://www.eff.org/deeplinks/2020/11/github-reinstates-youtube-dl-after-riaas-abuse-dmca

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/barakagb/gb-dl/issues/36#issuecomment-732331919, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJTRBJGN5GHWCQRW4ALFOTSRKQDTANCNFSM4T72GLTA .

berndverst commented 4 years ago

@barakagb since you originally licensed this under the MIT license and have never changed the license you cannot revoke the license for your old commits.

So I can just download and use this as the MIT License applies here. https://github.com/barakagb/gb-dl/tree/7ab871aea3c41d90979bb7a8ea1a0ce6e6dd69e6

If it works I'll still buy you the coffee ;)

barakagb commented 4 years ago

Go ahead and try it out.

On Tue, Nov 24, 2020, 00:25 Bernd Verst notifications@github.com wrote:

@barakagb https://github.com/barakagb since you licensed this under the MIT license you cannot revoke the license for your old commits.

So I can just download and use this as the MIT License applies here.

https://github.com/barakagb/gb-dl/tree/7ab871aea3c41d90979bb7a8ea1a0ce6e6dd69e6

If it works I'll still buy you the coffee ;)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/barakagb/gb-dl/issues/36#issuecomment-732435738, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJTRBJLQHLQW35NAG5Y6H3SRLHOHANCNFSM4T72GLTA .

berndverst commented 4 years ago

FYI - I was trying to use this for some other courses on teachable, but unfortunately their layout is different and I needed to make several code changes. Got it partially working - but still seemed to have missed some DOM elements leading to videos. Too much work for the time being, and I'm back from my vacation - so no longer need offline access.

barakagb commented 4 years ago

FYI - I was trying to use this for some other courses on teachable, but unfortunately their layout is different and I needed to make several code changes. Got it partially working - but still seemed to have missed some DOM elements leading to videos. Too much work for the time being, and I'm back from my vacation - so no longer need offline access.

@berndverst Noted. Please can share the teachable course url so I work on the fix (even though you no longer need the offline access) it might be beneficial to other people .Thanks

berndverst commented 4 years ago

@barakagb https://productionmusiclive.teachable.com/

Their sections have subsections with videos. And usually one of the first subsections in the introduction section isn't a video but instead a page talking about how to download the project files.

Would be awesome to download those automatically as well.

barakagb commented 4 years ago

Thanks let me see what I can do