search

barakwei / IRelectra

Electra A/C IR Encoder for IRremote
GNU General Public License v2.0
32 stars 10 forks source link

Cooling and other features don't work on arduino #2

Open urh opened 8 years ago

urh commented 8 years ago

Changed SendElectra and EncodeElectra have int in their params, but in the code their params are shifter up to 32 bits, even though they are 16 bits in arduino. Causes only the cooling and on/off options to work.

They should be uint32_t

barakwei commented 8 years ago

I prefer to create bitfield struct of the protocol which will make everything clearer and simpler

urh commented 8 years ago

Cool :) :+1:

barakwei commented 8 years ago

Interesting to see that in particle development environment which should be very similar to arduino, int has 4 bytes.

barakwei commented 8 years ago

I rewrote the library, and it's live on version-2.0 branch. Check it out, the issue should be fixed.