search

baranov1ch / node-vcdiff

node.js wrapper for open-vcdiff
MIT License
5 stars 2 forks source link

Cannot install: src/vcdiff.h has a syntax error #1

Open vphantom opened 8 years ago

vphantom commented 8 years ago

Hello,

Trying to install this using NPM on a system with G++ 4.9 I get the following error during compilation:

  CXX(target) Release/obj.target/vcdiff/src/vcd_decoder.o
In file included from ../src/vcd_decoder.h:14:0,
                 from ../src/vcd_decoder.cc:7:
../src/vcdiff.h:20:40: error: expected class-name before ‘{’ token
 class VcdCtx : public node::ObjectWrap {
                                        ^
../src/vcdiff.h:51:46: error: ‘Arguments’ in namespace ‘v8’ does not name a type
   static v8::Handle<v8::Value> New(const v8::Arguments& args);
                                              ^

...etc. My guess is that this is perhaps not compatible with Node.JS version 5?

wmsmacdonald commented 8 years ago

I successfully compiled the binaries on Node v6.2.0 after installing g++ v4.8, but only by manually cloning the repo and running node-gyp rebuild with a global install of node-gyp. Doing npm install doesn't seem to work in any case even after upgrading node-gyp.

Note that installing the module from git seems to compile for some reason. npm install baranov1ch/node-vcdiff