search

baranovskypd / goodpress

WIP!! :warning: R Package to Write Posts from R Markdown to Wordpress :warning:
https://maelle.github.io/goodpress/
Other
34 stars 5 forks source link

encoding #27

Closed maelle closed 3 years ago

maelle commented 3 years ago

Fix #26

@achateigner this corresponds to your fix I think. Now I wonder how to document the encoding argument, especially I wonder when that will be needed (and whether the default should really be UTF-8 :thinking: ).

Any insight will be appreciated, and as I have little time, I won't merge this right away anyway.

achateigner commented 3 years ago

@maelle I believe it corresponds. I think that the default should definitely be in UTF-8 as it is right now the most common encoding in the world, and this is what you want for your encoding. I don't think that you should worry too much about the documentation about it, R only supports specifically UTF-8 and Latin-1, the later being way less universal. Also, mySQL is UTF-8 aware. Maybe you can write Encoding argument passed to base::readLines, defaults to UTF-8.

maelle commented 3 years ago

What I wonder about is whether how one saved the index.Rmd makes any difference. I'll think about it a bit more.

@henrywangnl if you use goodpress again would you mind testing this branch to check it doesn't break anything for you? Thanks.

henrywangnl commented 3 years ago

Hi Maelle,

Thanks for getting back to me. You mean reinstall goodpress and see if it works? I'll let you know how it goes next time I post.

Thanks, Henry

On Mon, Aug 3, 2020, 1:34 PM Maëlle Salmon notifications@github.com wrote:

What I wonder about is whether how one saved the index.Rmd makes any difference. I'll think about it a bit more.

@henrywangnl https://github.com/henrywangnl if you use goodpress again would you mind testing this branch to check it doesn't break anything for you? Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/maelle/goodpress/pull/27#issuecomment-667972323, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE7BXKHBL6XIUJVVXHUP3DLR62OEVANCNFSM4PSQDNTQ .

maelle commented 3 years ago

Yes but with remotes::install_github("maelle/goodpress", ref = "encoding").

This won't fix your images issue sadly, I'd just like to know whether it introduces any new bug 😬 No hurry!

henrywangnl commented 3 years ago

Yes but with remotes::install_github("maelle/goodpress", ref = "encoding").

This won't fix your images issue sadly, I'd just like to know whether it introduces any new bug 😬 No hurry!

Hi @maelle

I tested it with my new post and it was going well. Didn't see any new bugs.

Thanks, Henry

maelle commented 3 years ago

thanks a lot @henrywangnl