search

baranovskypd / goodpress

WIP!! :warning: R Package to Write Posts from R Markdown to Wordpress :warning:
https://maelle.github.io/goodpress/
Other
34 stars 5 forks source link

fix image issue #28

Closed henrywangnl closed 3 years ago

henrywangnl commented 3 years ago

22 fixed the image issue

maelle commented 3 years ago

Can you please explain the change? Thanks in any case!

henrywangnl commented 3 years ago

As I said in the issue comments, the media is a data frame, so length(media) and seq_along(media) are not what we want. They just look for the first two images in a post and replace them with WordPress media URLs.

This PR literally just use !Is.null(media) and 1: nrow(media) instead.

Hope it's clear enough.

On Tue, Oct 27, 2020, 6:22 AM Maëlle Salmon notifications@github.com wrote:

Can you please explain the change? Thanks in any case!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/maelle/goodpress/pull/28#issuecomment-716989592, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE7BXKHP5JWQCRS54NBACWLSMZKJTANCNFSM4S7WXJFA .

maelle commented 3 years ago

oooh sorry now i got it, good catch!! And so this fixes your issue?

Can you change your role in DESCRIPTION from ctb to aut?

I'll merge tomorrow. Thanks a ton!

henrywangnl commented 3 years ago

oooh sorry now i got it, good catch!! And so this fixes your issue?

Can you change your role in DESCRIPTION from ctb to aut?

I'll merge tomorrow. Thanks a ton!

Yes, the issue is fixed and I changed my role :-) Thanks!

maelle commented 3 years ago

Thanks a ton and well done!