Closed Kjeldgaard closed 3 years ago
Hi @Kjeldgaard, thanks for the PR !
This feature is bothering me:
go-exiftool
if exiftool
behaviour changes too much
For instance, if the provided parameters change the extracted metadata serialization in a way that go-exiftool
does not support, the library will behave incorrectlyExiftool
supports so many parameters that it will be really hard to test and filter.
But since I consider that this feature might interest some users, let's do this this way:
Advanced usage
in the README.MD and give a real example for this functional optionHi barasher,
Thanks for your comment. I totalky understand your concerns about this change, as it could break go-exiftool functionality. Since it is actually only the "-n" argument I need, I have come to the conclusion that it would probably be better to achieve this similarly to the charset implementation. What do you think?
I've taken a look at exiftool's -n
parameter : I agree with you, a dedicated "functional option" seems to be the best option.
Deal ! Can you handle it ?
I've made a new dedicated function for 'No Print Conversion'. What do you think?
Just a little godoc fix and that will be perdect :)
Didn't know that was a thing :) It should be fixed now.
Thanks a lot @Kjeldgaard , I'll merge this feature tomorrow and release a new version
You're welcome. Glad I could contribute to go-exiftool.
New function which adds initial arguments to be parsed to exiftool.