search

barasher / go-exiftool

Golang wrapper for Exiftool : extract as much metadata as possible (EXIF, ...) from files (pictures, pdf, office documents, ...)
GNU General Public License v3.0
245 stars 43 forks source link

Extracting pictures using -b option #33

Closed squarebrakets closed 3 years ago

squarebrakets commented 3 years ago

Finally made it work. Thanks for your time.

barasher commented 3 years ago

Thanks for the PR, but I don't think that it is not configurable enough : you're just considering the "field" that you're interreted in (-picture argument). Some other users might want to extract another field. The good way to do it (on my mind) is to let the user choose which binary field he wants to extract.

I also think that exiftool's current behaviour is incompatible with the one described above, it should be another struct that extract (only) binaries.

Thanks again for your PR, but I'd rather prefer to code this feature myself. But I'll use for use a part of this PR.

squarebrakets commented 3 years ago

Okay