barasher / go-exiftool

Golang wrapper for Exiftool : extract as much metadata as possible (EXIF, ...) from files (pictures, pdf, office documents, ...)
GNU General Public License v3.0
251 stars 44 forks source link

Minor readability and code enhancments #4

Closed Hexoplon closed 4 years ago

Hexoplon commented 4 years ago

Fixes introduced based on golangci-lint using the --enable-all flag

codecov-io commented 4 years ago

Codecov Report

Merging #4 into master will decrease coverage by 1.41%. The diff coverage is 86.36%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #4      +/-   ##
=========================================
- Coverage   87.02%   85.6%   -1.42%     
=========================================
  Files           2       2              
  Lines         131     132       +1     
=========================================
- Hits          114     113       -1     
- Misses         11      12       +1     
- Partials        6       7       +1
Impacted Files Coverage Δ
filemetadata.go 100% <100%> (ø) :arrow_up:
exiftool.go 71.21% <57.14%> (-2.64%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 620887f...d6945f2. Read the comment docs.

Hexoplon commented 4 years ago

@barasher Reverted to using constants while maintaining the minor enhancments. Renamed PR title

barasher commented 4 years ago

Thanks for the PR :)