barasher / go-exiftool

Golang wrapper for Exiftool : extract as much metadata as possible (EXIF, ...) from files (pictures, pdf, office documents, ...)
GNU General Public License v3.0
245 stars 43 forks source link

Using exec.Cmd pipes for stdout and stderr which don't deadlock and a… #69

Open agorman opened 1 year ago

agorman commented 1 year ago

…re closed properly by call to wait

This would solve #68. I haven't fixed the failing tests yet and wanted to get your opinion.

Thanks!

agorman commented 1 year ago

@barasher any thoughts on this?

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 50.00% and project coverage change: -1.35 :warning:

Comparison is base (b9a9a53) 80.80% compared to head (97132af) 79.46%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #69 +/- ## ========================================== - Coverage 80.80% 79.46% -1.35% ========================================== Files 2 2 Lines 297 297 ========================================== - Hits 240 236 -4 - Misses 40 42 +2 - Partials 17 19 +2 ``` | [Impacted Files](https://app.codecov.io/gh/barasher/go-exiftool/pull/69?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [exiftool.go](https://app.codecov.io/gh/barasher/go-exiftool/pull/69?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-ZXhpZnRvb2wuZ28=) | `70.95% <50.00%> (-1.91%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

barasher commented 1 year ago

I'm so sorry @agorman, I really did not have time to check it yet. I'm running out of time these last week's but it should be better in one or two weeks. I do not forget this PR.

agorman commented 1 year ago

@barasher thanks for the update. I'm not in a big hurry on this so don't stress about it. When you have some extra time take a look.

Thanks!

agorman commented 10 months ago

@barasher bump :)