baratgabor / MyWarehouse

Clean Architecture and Domain Driven Design sample project based on C# 10 / .NET 6 / ASP.NET Core 6 / EF Core 6 & Angular 11 with Bootstrap.
MIT License
243 stars 69 forks source link

Changing page size doesn't reset current page index #5

Closed baratgabor closed 3 years ago

baratgabor commented 3 years ago

Should have been fixed already previously, but apparently not.

It can cause empty result pages when the result set updates, if a larger page size is selected.

Area: Check it at transaction index, product index, partner index; all should consistently reset set to reasonably expected page index (i.e. if displaying 21-60 with page size 20, switching to size 5 should display 21-25).

Note that using row index in the query model instead of page index would be actually better with respect to this, because we could always continue paging from the same position. Currently if we're showing e.g. 16-20 with page size 5, switching to page size 20 will only support resetting the view to 1-20.