barbaLab / nigeLab

Neurophysiological data analyses by engineers, for physiologists.
GNU General Public License v3.0
14 stars 2 forks source link

nigelObj improvements #81

Closed Nabarb closed 4 years ago

Nabarb commented 4 years ago

Incremental update and small bugfixes. Can you please triple check checkAnimalsForClones? I've done enough damages with my bad coding for today.

Bugfix on addchild. Parent is now assigned properly when multiple chidren are added at once.

Bugfix on reload. Reloading transient properties was causing their value to be overwritten by null or empty. Now they are skipped during reload.

Bugfix on checkAnimalsForClones. It wasn't warking at all. I ended up rewriting it simplifying it a bit.

Added lookForData function. While loading if no children are added to the loaded obj (because none ere found) the user is prompted to select the correct data folder. This triggers a path update for the nigelObj (and subsequently loaded children).

m053m716 commented 4 years ago

Will try and look this over tonight. Depending on how it looks I might need one more day to go over it, but hopefully try and get through it quickly so you can keep doing Pull Requests- thanks!

To Do

Nabarb commented 4 years ago

There is an issue with lookForData. At this point it is called when no children are found. If a tank is moved from a pc to another though it might try to save a .nigelTank at the old location. This might end up with an Access Denied error