search

barbagroup / JITcode-MechE

Online learning modules to learn computing in a problem-based context within Mechanical Engineering
MIT License
7 stars 5 forks source link

New Lesson 2 #22

Closed gforsyth closed 10 years ago

gforsyth commented 10 years ago

Here's a new Lesson 2, based on siting wind turbines given wind data from a few locations.

Questions, comments and suggestions are most welcome.

http://nbviewer.ipython.org/github/barbagroup/JITcode-MechE/blob/windspeed/lessons/02_Lesson02_Units_and_Decisions.ipynb

ahmadia commented 10 years ago

This is very impressive. There is also a lot to review here. You should probably try to follow the PEP 8 style guide for variable and function names. For example, checkandconvert should be check_and_convert. Also, the plots might look better as scatter plots than line plots, with slightly thicker markers?

gforsyth commented 10 years ago

function names have been changed, thanks for that. I'll play around with the plots -- I tried a few variations and they all look pretty bad before convolution. Might make sense to split the two years of data into two separate plots.