search

barbagroup / geoclaw

A fork of GeoClaw (http://www.clawpack.org/geoclaw) for hydrocarbon overland flow
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Subroutine qad #13

Open piyueh opened 5 years ago

piyueh commented 5 years ago

It seems the subroutine qad (in src/2d/shallow/qad.f) is doing something I don't understand. The comment shows some remarks like need to fix someday from upstream GeoClaw code. I doubt this has something to do with that, in coarse grids, the fluid will penetrate the hydro regions by two cells. The expected behavior is only penetrating one cell. Though for the fine grids, they are not affected.

mandli commented 5 years ago

That routine is a conservative fix-up around the boundaries of a grid patch as described in [1]. The "need to fix someday" was fixed (hence the commented out return statement) but the source terms are not evaluated as there isn't an idea of what the right thing to do is there.

  1. Berger, M. J. & LeVeque, R. J. Adaptive Mesh Refinement Using Wave-Propagation Algorithms for Hyperbolic Systems. 35, 2298–2316 (1998).