barbatus / angular2

Angular2 Packaged for Meteor
14 stars 10 forks source link

Caching compilers #2

Closed DAB0mB closed 9 years ago

DAB0mB commented 9 years ago
DAB0mB commented 9 years ago

No I did not test it yet, I have problems with the master branch, angular2 and Meteor-Angular2 does not seem to work together, for instance, Meteor-Angular2 requires angular2@5.0.0 while the latest version is 4.6.0, and whenever I try to run them, I encounter errors like so:

Error: Cannot find module 'reflect-metadata' from '/home/user/Workspace/urigo:angular2-meteor/examples/parties/packages/angular2/.npm/package'

Can you please tell me if I'm missing something so I can test it?

barbatus commented 9 years ago

@DAB0mB There is some issue with cosmos:browserify@0.7.0 going on, I've just reverted it back to 0.5.0. Please check it now.

DAB0mB commented 9 years ago

Great, I will test my PR and tell you when I finish, thanks for the comments!

DAB0mB commented 9 years ago

I'm sorry, I'm still having difficulties running the parties app in the example:

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: Cannot find module 'es6-shim' from '/home/user/Workspace/urigo:angular2-meteor/examples/parties/packages/angular2/.npm/package'
    at /home/user/.meteor/packages/cosmos_browserify/.0.7.0.16dslah++os+web.browser+web.cordova/plugin.CosmosBrowserify.os/npm/CosmosBrowserify/node_modules/browserify/node_modules/resolve/lib/async.js:46:17
    at process (/home/user/.meteor/packages/cosmos_browserify/.0.7.0.16dslah++os+web.browser+web.cordova/plugin.CosmosBrowserify.os/npm/CosmosBrowserify/node_modules/browserify/node_modules/resolve/lib/async.js:173:43)
    at ondir (/home/user/.meteor/packages/cosmos_browserify/.0.7.0.16dslah++os+web.browser+web.cordova/plugin.CosmosBrowserify.os/npm/CosmosBrowserify/node_modules/browserify/node_modules/resolve/lib/async.js:188:17)
    at load (/home/user/.meteor/packages/cosmos_browserify/.0.7.0.16dslah++os+web.browser+web.cordova/plugin.CosmosBrowserify.os/npm/CosmosBrowserify/node_modules/browserify/node_modules/resolve/lib/async.js:69:43)
    at onex (/home/user/.meteor/packages/cosmos_browserify/.0.7.0.16dslah++os+web.browser+web.cordova/plugin.CosmosBrowserify.os/npm/CosmosBrowserify/node_modules/browserify/node_modules/resolve/lib/async.js:92:31)
    at /home/user/.meteor/packages/cosmos_browserify/.0.7.0.16dslah++os+web.browser+web.cordova/plugin.CosmosBrowserify.os/npm/CosmosBrowserify/node_modules/browserify/node_modules/resolve/lib/async.js:22:47
    at Object.oncomplete (fs.js:108:15)

Each time the module not found is different, seems like an async problem.

barbatus commented 9 years ago

@DAB0mB As I can see in the logs, cosmos:browserify@0.7.0 is still there. If you sync'ed with the last commit, then, try 1) remove .meteor/version file, remove .meteor/local and re-run app.

DAB0mB commented 9 years ago

The application seems to run now, there is only one problem though. The default layout in {barbatus:angular2} client/index.html seems to be ignored when processing files, therefor there is no way to make a default layout. Do you have any suggestions?

barbatus commented 9 years ago

@DAB0mB I guess, by ignoring the default layout, you mean - it's not shown anything?

DAB0mB commented 9 years ago

@barbatus When processing files for target, the files array contains only the html files in the application, not other packages. I also tried putting it in urigo:meteor-angular2, unfortunately it doesn't work.

barbatus commented 9 years ago

@DAB0mB I always have hard time to understand you. Why should I have guessed that phrase default layout has nothing to do with the issue? Why not to just have said - I added a file client/index.html to the package but it doesn't get to html file processor?

What I can guess if there is a file, for example, main.jsx in this package and it's being processed by jsx-processor, same way any html-file should go through the html-processor in this package.

So, I can advice only to try to re-check this file is really in place, then try to re-check if what actually appears in the processor one more time by logging out all files are going through.

DAB0mB commented 9 years ago

@barbatus I will try to be clearer from now on. Yes I would have also expect the html files to go through the processor, I've checked several times that the file is located and named correctly, I've tried moving it to different locations, but it doesn't seem to work. Maybe it's something in Meteor's implementation, maybe if html files are being watched it will only refer to the files in the application.

barbatus commented 9 years ago

@DAB0mB I don't see you've added it to the package.js like api.addFiles(['client/index.html'])

DAB0mB commented 9 years ago

@barbatus Thanks! I knew I've missed something. Everything seems to work fine now.

DAB0mB commented 9 years ago

@barbatus I did a little refactoring and reverted to ts non-caching compiler.