search

barbatus / ng2-meteor-accounts

Meteor Accounts for Angular2
13 stars 2 forks source link

Any plans to update this project for newer angular2 conventions? #8

Open denodaeus opened 8 years ago

denodaeus commented 8 years ago

I've tried to get this to work in a project that's using angular2-rc0 -- the main problem I'm having is that it seems typings are bundled in this module and pollute the project space.

Do you have plans to update this package a newer angular2 (and drop the typings in the package)?

Example:

> Started proxy.
=> Started MongoDB.
***** Typings that have been added/updated *****
typings/angular2/angular2.d.ts
typings/angular2/common.d.ts
typings/angular2/core.d.ts
typings/angular2/http.d.ts
typings/angular2/router.d.ts
typings/angular2/platform/browser.d.ts
imports/ui/administration/organization/create/create-organization.component.ts (12, 33): Cannot find module 'angular2-meteor'.
imports/ui/administration/organization/create/create-organization.component.ts (13, 46): Cannot find module '@angular/core'.
imports/ui/administration/organization/create/create-organization.component.ts (14, 55): Cannot find module '@angular/common'.
imports/ui/administration/organization/create/create-organization.component.ts (22, 28): Cannot find module '../../../../thirdparty/ng2-meteor-accounts/annotations.ts'.
imports/ui/administration/organization/create/create-organization.component.ts (24, 24): Cannot find module '@angular/router-deprecated'.
imports/ui/administration/organization/create/create-organization.component.ts (73, 10): Property 'subscribe' does not exist on type 'OrganizationCreateFormComponent'.
imports/ui/administration/organization/edit/edit-organization.component.ts (12, 77): Cannot find module '@angular/core'.
imports/ui/administration/organization/edit/edit-organization.component.ts (14, 33): Cannot find module 'angular2-meteor'.
imports/ui/administration/organization/edit/edit-organization.component.ts (18, 28): Cannot find module '../../../../thirdparty/ng2-meteor-accounts/annotations.ts'.
imports/ui/administration/organization/edit/edit-organization.component.ts (19, 37): Cannot find module '@angular/router-deprecated'.
imports/ui/administration/organization/edit/edit-organization.component.ts (123, 10): Property 'subscribe' does not exist on type 'OrganizationEditFormComponent'.
imports/ui/administration/organization/edit/edit-organization.component.ts (126, 32): Property 'subscribe' does not exist on type 'OrganizationEditFormComponent'.
imports/ui/test-case-library/test-case-view/test-case-property/test-case-property.component.ts (12, 72): Cannot find module '@angular/core'.
imports/ui/test-case-library/test-case-view/test-case-property/test-case-property.component.ts (13, 33): Cannot find module 'angular2-meteor'.
imports/api/test-case/execution-status/execution-status.service.ts (11, 28): Cannot find module '@angular/core'.
imports/api/test-case/priority/priority.service.ts (11, 28): Cannot find module '@angular/core'.
imports/api/test-case/status/status.service.ts (11, 28): Cannot find module '@angular/core'.
denodaeus commented 8 years ago

Also, I tried just copy/pasting the code into my project instead of installing it as a module to get around the above issues.

The problem with this is you use es6-promise, which doesn't play nicely if using other polyfils (es6-shim, core-js) that include a promise implementation.

It also uses system.js, which causes a lot of unnecessary packages to come into the project when i install ng2-meteor-accounts, which causes a whole other class of issues.

ayazhussein commented 7 years ago

any updates? @barbatus