search

barbeau / gpstest

The #1 open-source Android GNSS/GPS test program
Apache License 2.0
1.78k stars 364 forks source link

Share: Altitude output doesn't respect "feet" setting #591

Open barbeau opened 2 years ago

barbeau commented 2 years ago

Describe the bug If you change the preferred distance units to feet instead of meters, the "Share" output is still meters above WGS84 ellipsoid. This also isn't obvious because the units aren't shown.

To Reproduce Steps to reproduce the behavior:

  1. Go to Settings and change "Preferred distance units" to feet
  2. Go to Status and tap "Share" icon in action bar

Expected behavior Altitude should be shown in feet, or it should be obvious that altitude is still in meters. I'd prefer to convert to feet.

Observed behavior Altitude is shown in meters

Screenshots:

image

gdt commented 2 years ago

I don't understand. The share output is a format that is basically a protocol, and the right thing is to understand the protocol spec (or what it would be if written down correctly) and then meet it. The idea of putting feet in a geo: URI is puzzling to me.

So: who would consume this output? How would they know?

barbeau commented 2 years ago

Yes, I wouldn't change the actual geo: URI shared when tapping on the Share button. The text shown in the UI isn't the geo: protocol, it's there more for a quick copy/paste as human readable text. So it seems reasonable to me to show that in feet if the user has selected this as a preference. Either way the units should be indicated in the UI so it's clear what is being shown.