search

barbeau / gpstest

The #1 open-source Android GNSS/GPS test program
Apache License 2.0
1.78k stars 364 forks source link

Add SouthPAN to SatelliteUtil,kt #599

Closed davecollett closed 2 years ago

davecollett commented 2 years ago

SouthPAN has PRN122 assigned

Please make sure these boxes are checked before submitting your pull request - thanks!

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

davecollett commented 2 years ago

This is related to https://github.com/barbeau/gpstest/issues/598 SouthPAN is expected to begin early services on PRN122 later this year.

davecollett commented 2 years ago

Sorry, was a bit premature with this pull request, will look to replicate this PR: https://github.com/barbeau/gpstest/commit/5373ddbbfee5d8742f7bad0086408c26aa23a644

barbeau commented 2 years ago

@davecollett Thanks for working on this! Yes, that commit is a good model. You'll need to add the new type to the enumeration. For this one need to add a flag image as well and include it in Status and Sky user interface code. Here's Status: https://github.com/barbeau/gpstest/blob/b4f18fc3454009d82780a5fe3fa8fbfbd6f475fa/GPSTest/src/main/java/com/android/gpstest/ui/status/StatusScreen.kt#L240

And Sky: https://github.com/barbeau/gpstest/blob/b4f18fc3454009d82780a5fe3fa8fbfbd6f475fa/GPSTest/src/main/res/layout/gps_sky_legend_card.xml#L35

davecollett commented 2 years ago

Happy to try and help, i really appreciate the app. The flag is a bit of a challenge to represent the two countries, but will come up with something.

On Wed, 24 Aug 2022, 12:38 am Sean Barbeau, @.***> wrote:

@davecollett https://github.com/davecollett Thanks for working on this! Yes, that commit is a good model. You'll need to add the new type to the enumeration. For this one need to add a flag image as well and include it in Status and Sky user interface code. Here's Status:

https://github.com/barbeau/gpstest/blob/b4f18fc3454009d82780a5fe3fa8fbfbd6f475fa/GPSTest/src/main/java/com/android/gpstest/ui/status/StatusScreen.kt#L240

And Sky:

https://github.com/barbeau/gpstest/blob/b4f18fc3454009d82780a5fe3fa8fbfbd6f475fa/GPSTest/src/main/res/layout/gps_sky_legend_card.xml#L35

— Reply to this email directly, view it on GitHub https://github.com/barbeau/gpstest/pull/599#issuecomment-1224012834, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKRE2FKEBH4CJHDNOX2T4TV2TA5JANCNFSM57JE3EUQ . You are receiving this because you were mentioned.Message ID: @.***>