barbeau / gpstest

The #1 open-source Android GNSS/GPS test program
Apache License 2.0
1.78k stars 364 forks source link

Wear OS - Add LockIcon when GPS fix is acquired #610

Open barbeau opened 1 year ago

barbeau commented 1 year ago

Is your feature request related to a problem? Please describe. Currently the Wear OS version shows a progress bar while waiting for a fix, which is good. This disappears after a fix is obtained. At this point it's not as clear to the user that a fix has been obtained, especially if it's obtained very quickly. Users previously complained about this in the Status screen of the mobile app, which is why I added a lock icon to that screen when a fix is obtained.

Describe the solution you'd like

When a fix is obtained on Wear OS, we should show a "lock" icon where the progress bar was. If a fix is lost, then the lock icon should disappear and the progress bar should be shown again. In other words, we want to duplicate the same behavior as the Status screen in the mobile app in the Wear OS app.

Here is the LockIcon composable used in Status screen in mobile app:

@adaext Is this something you could tackle?

Describe alternatives you've considered Do nothing - leave as-is

barbeau commented 1 year ago

As mentioned in https://github.com/barbeau/gpstest/issues/613, we should copy the LockIcon to the library and use the same code in the mobile app and Wear OS version.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you!

barbeau commented 1 year ago

Not stale

stale[bot] commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you!

barbeau commented 6 months ago

Not stale