search

barbeau / gpstest

The #1 open-source Android GNSS/GPS test program
Apache License 2.0
1.78k stars 364 forks source link

Map screen lacks required OSM attribution (F-Droid build) #620

Closed gdt closed 1 year ago

gdt commented 1 year ago

Describe the bug In the F-Droid build, the map tab shows OSM data and lacks the required attribution.

To Reproduce Steps to reproduce the behavior:

  1. Install from F-Droid main repo
  2. In hamburger menu, select Map

Expected behavior The OSM map should have attribution per https://www.openstreetmap.org/copyright

Observed behavior No attribution, and a fortiori no clickable link to the license.

App, Device and Android version:

GPSTest v3.9.16 CalyxOS based on AOSP 13

Comment

It's likely quite clear from source code that attribution isn't attempted, so I'm not going to go into further details proving it is missing unless that' s actually in dispute.

gdt commented 1 year ago

@AntoninDelFabbro your comment about attribution is valid in substance, even if coming across as non-collaborative in tone. I myself am an osm editor, and often cranky about the license, but I reserve serious crankiness for people attempting to get something for themselves, vs people contributing to the free software ecosystem.

Perhaps you know how to fix, and could prepare a PR?

barbeau commented 1 year ago

@gdt @AntoninDelFabbro Thanks for flagging this, it fell off my radar and got mixed in with the issue of supporting local OSM tiles (https://github.com/barbeau/gpstest/issues/531). I'll add the license attribution in the next release.

AntoninDelFabbro commented 1 year ago

You're welcome & no worries! Thanks to you for this awesome (and FOSS) app!