barbeau / gpstest

The #1 open-source Android GNSS/GPS test program
Apache License 2.0
1.78k stars 364 forks source link

Update targetSdkVersion to 33 #622

Open barbeau opened 1 year ago

barbeau commented 1 year ago

Is your feature request related to a problem? Please describe. Targeting sdk version 33 requires handle runtime notification: https://developer.android.com/about/versions/13/behavior-changes-all#notification-permission

I've started a branch here, but there are weird interactions between the activity and service lifecycle when introducing a dialog for the notification permission, so it requires additional reorganization of this code: https://github.com/barbeau/gpstest/tree/runtimeNotificationPermissions

Describe the solution you'd like As mentioned above and in https://github.com/barbeau/gpstest/issues/619#issuecomment-1504035392, we need to eventually update to targetSdkVersion 33, which requires handling notification runtime permissions.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you!

barbeau commented 1 year ago

Not stale

stale[bot] commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you!

barbeau commented 5 months ago

Not stale