Add proper implementation for BDSBAS

barbeau / gpstest

The #1 open-source Android GNSS/GPS test program

Apache License 2.0

1.74k stars 361 forks source link

Add proper implementation for BDSBAS #660

Closed Narugakuruga closed 4 months ago

Narugakuruga commented 11 months ago

Add PNR 130, 143, 144 to carrier frequency test. Add sky view flags using existing asset. Update SbasType and string to match names. SNAS only exist in very old press release. So rename to BDSBAS now.

Hopefully it won't affect database too much. There's 20 records of "SNAS" right now. But the signal is marked as "testing, do not use" anyway. I wonder why these device is using them

[x] Acknowledge that you're contributing your code under Apache v2.0 license
[x] Apply the AndroidStyle.xml style template to your code in Android Studio.

Narugakuruga commented 11 months ago

@barbeau Glad to have your review Mr barbeau! I would like to know what went wrong with the CI

barbeau commented 11 months ago

@Narugakuruga you should be able to click through on the CI link that failed, and then just scrolled at the bottom of the CI log. It should show what errors prevented the build from completing. If you take a look and can't see the problem let me know and I'll take a closer look.

Narugakuruga commented 10 months ago

Sorry, I was trying to label the sbas as B2a, But the code is out putting L5. Can you please help me check what is wrong? I think I must miss something.

05.7221640Z com.android.gpstest.CarrierFreqUtilsTest > testGetCarrierFrequencyLabel[test(AVD) - 10] [31mFAILED [0m 2023-11-06T03:44:05.7222930Z junit.framework.ComparisonFailure: expected:<[B2a]> but was:<[L5]> 2023-11-06T03:44:05.7224260Z at junit.framework.Assert.assertEquals(Assert.java:85) 2023-11-06T03:44:06.8674750Z Tests on test(AVD) - 10 failed: There was 1 failure(s). 2023-11-06T03:44:07.9973330Z 2023-11-06T03:44:07.9979090Z > Task :GPSTest:connectedGoogleDebugAndroidTest FAILED

stale[bot] commented 4 months ago

This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you!