barbequesauce / Watcher3

Fork of nosmokingbandit/Watcher3 as the original seems inactive. PRs welcome, support is community based.
Other
69 stars 19 forks source link

Latest commit deleted plugin #194

Open jamaroney opened 3 years ago

jamaroney commented 3 years ago

Several days ago I created a python script located in the /plugins/finished directory. Within the last few hours, Watcher upgraded automatically to the latest commit, and now the file is gone.

Is this a bug? Does it have anything to do with the .gitignore file in that directory? Should I delete or edit .gitignore? After searching on the internet, I'm still unsure how it works.

barbequesauce commented 3 years ago

Does the .gitignore look different from these?

pi@pi:~ $ cat /opt/watcher3/plugins/added/.gitignore
# Ignore everything in this directory
*
# Except this file
!.gitignore
pi@pi:~ $ cat /opt/watcher3/plugins/finished/.gitignore
# Ignore everything in this directory
*
# Except this file
!.gitignore
pi@pi:~ $ cat /opt/watcher3/plugins/snatched/.gitignore
# Ignore everything in this directory
*
# Except this file
!.gitignore
pi@pi:~ $
jamaroney commented 3 years ago

All of them are as shown above

barbequesauce commented 3 years ago

unfortunately I cant reproduce this...

Are the permissions on .gitignore set to -rw-r--r--?

jamaroney commented 3 years ago

No, they were -rw-rw-rw. I'll change that ASAP.

What should the permissions be for the python script(s) within each plugins sub-directory?

barbequesauce commented 3 years ago

I dont see any expectations from the Watcher perspective - that said, mine are all 0644, just like .gitignore.