search

barberscore / barberscore-api

Contest Registration and Scoring System for the Barbershop Harmony Society International convention
https://www.barberscore.com
BSD 2-Clause "Simplified" License
12 stars 4 forks source link

Flag to indicate song missing/duplicated songs #545

Open CLBuechler2324 opened 5 years ago

CLBuechler2324 commented 5 years ago

When Finish Appearance button selected, need a logic check to see if Song 1 or Song 2 are Null or are identical to each other. CA would then have a button to Confirm Songs Titles - like we have to Re-Verify if variance indicated. This would eliminate CA oversight of selected same song twice or missing song in repertory.

millsjdm commented 5 years ago

To further clarify this feature request... this should still allow for a CA to "re-verify" in those cases where the song was indeed NOT in the repertory. In that case (when re-verifying), the CA is explicitly saying - "yep, I know... we double-checked with the quartet, and indeed, they didn't have their song in the repertory - so I'm verifying that I intentionally did not select one of their song titles".

We're just trying to reduce the possibility of a CA error propagating it's way in to the OSS to have a "[Song title not in group's repertory]" - when that was not the actual case.

CLBuechler2324 commented 5 years ago

I suggested “Confirm songs” since verify & re-verify are used already for some verification.

On Jun 12, 2019, at 3:25 PM, David Mills <notifications@github.com mailto:notifications@github.com> wrote:

To further clarify this feature request... this should still allow for a CA to "re-verify" in those cases where the song was indeed NOT in the repertory. In that case (when re-verifying), the CA is explicitly saying - "yep, I know... we double-checked with the quartet, and indeed, they didn't have their song in the repertory - so I'm verifying that I intentionally did not select one of their song titles".

We're just trying to reduce the possibility of a CA error propagating it's way in to the OSS to have a "[Song title not in group's repertory]" - when that was not the actual case.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/barberscore/barberscore-api/issues/545?email_source=notifications&email_token=ALRTG5ERAEJ7P7DPZE3P563P2FER7A5CNFSM4HXEIZGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXRRMTA#issuecomment-501421644, or mute the thread https://github.com/notifications/unsubscribe-auth/ALRTG5DCNMBWUGRXN4QS4ILP2FER7ANCNFSM4HXEIZGA.