barbigrade / capstone-project

Neuefische bootcamp final project
https://dailybread.vercel.app/
0 stars 0 forks source link

Add toggle function and add to cart button #15

Open barbigrade opened 1 year ago

barbigrade commented 1 year ago

Value Proposition

As a customer I need to be able to select the items I want to buy to add them to my shopping cart at a later stage

Description

#7 add to cart button after toggle

Acceptance Criteria

Tasks

ben-me commented 1 year ago

Hey, looks good to me except for these two sentences 😁

to be to add them to my shopping cart at a later stage On click, the product cards on each bakery overview page can be toggled to extend

One question about the tasks: I assume the Cards themselves are created from a component. Why do you want to create the button as a seperate component instead of adding them to the existing card component (like you plan to do with the extension logic)?

barbigrade commented 1 year ago

Hey @ben-me , thank you for looking this over! It's a great day for poor grammar and typos 😅

Re: the button component, I see what you mean. Initially, I thought it would make it easier to reuse the component elsewhere at a different point in time but your suggestion makes more sense I think :) Thanks again!

ben-me commented 1 year ago

There isn't really a right or wrong with the button component. If you need it outside of the cards then it's probably smarter to create a new component. Just thought that if they are only available on the cards you could add them to the existing component.